Wireshark-commits: [Wireshark-commits] master-2.2 74b3fa4: Qt: fix a NULL pointer dereference in ex
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 4 Aug 2016 18:11:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=74b3fa43536f929b1278f699bcb2b44dd6e104a6
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

74b3fa4 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: fix a NULL pointer dereference in extcap_argument_multiselect.cpp
    
    Guard treeView dereference by a cehck on viewModel (as it is done elsewhere in
    the file, both are allocated at the same time).
    This can happen for example when USBPcap lists a USB Hub with no devices connected.
    
    Change-Id: Iee412b8c95539e9e3d65706c14f62194cafcaffc
    Reviewed-on: https://code.wireshark.org/review/16885
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    (cherry picked from commit 6168d8bf809edf514f6356c2c35afb41e6eedf36)
    Reviewed-on: https://code.wireshark.org/review/16887
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    

Actions performed:

    from  54bf645   extcap: Use stderr to print error message
    adds  74b3fa4   Qt: fix a NULL pointer dereference in extcap_argument_multiselect.cpp


Summary of changes:
 ui/qt/extcap_argument_multiselect.cpp |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)