Wireshark-commits: [Wireshark-commits] master d04be01: Ply parser updated to 3.8 from http://www.da
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 4 Aug 2016 08:20:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d04be0149d1942e691030d20e52e94ed2eabfab6
Submitter: João Valverde (j@xxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d04be01 by Balint Reczey (balint@xxxxxxxxxxxxxxx):

    Ply parser updated to 3.8 from http://www.dabeaz.com/ply/
    
    The Ubuntu packaged Ply 3.7 with Ubuntu 16.04's Python makes
    ASN.1 based dissector generation fail.
    
    Ply's API changed after 3.5 and the small change to asn2wrs.py
    adapts to that.
    The commit breaking the API in Ply's repository is the following:
    
     commit af651673ba6117a0a5405055a92170fffd028106
     Author: David Beazley <dave@xxxxxxxxxx>
     Date:   Tue Apr 21 16:31:32 2015 -0500
    
        Added optional support for defaulted states
    
    Change-Id: I1db33fdcccf7c39ecdb0e435a5ea9183362471ad
    Bug: 12621
    Reviewed-on: https://code.wireshark.org/review/16864
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    Petri-Dish: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    Tested-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  92eecfd   Add ISO15765 dissector
    adds  d04be01   Ply parser updated to 3.8 from http://www.dabeaz.com/ply/


Summary of changes:
 tools/asn2wrs.py |    3 +-
 tools/lex.py     |  822 +++++++++++-----------
 tools/yacc.py    | 2044 +++++++++++++++++++++++++++++-------------------------
 3 files changed, 1522 insertions(+), 1347 deletions(-)
 mode change 100755 => 100644 tools/lex.py
 mode change 100755 => 100644 tools/yacc.py