Wireshark-commits: [Wireshark-commits] master-2.0 ec706c9: SSL utils: Add proper check while gettin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 3 Aug 2016 22:28:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ec706c90cda716e8cc3757110038aefb33f741db
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

ec706c9 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    SSL utils: Add proper check while getting bag type
    
    Implementing proper return value check, as done for other gnutls function
    calls, catches (unlikely) errors and allows C++ compatible build.
    
    Change-Id: Idf5bd3fe6e68d006a469fe72663dea1c7e2d17f7
    Reviewed-on: https://code.wireshark.org/review/16865
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 9affd2656c9c2f6e911817f196a524f4b5b2c1cd)
    Reviewed-on: https://code.wireshark.org/review/16867
    

Actions performed:

    from  f5c7b56   Don't snprintf() into a string with one of the arguments being the same string.
    adds  ec706c9   SSL utils: Add proper check while getting bag type


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)