Wireshark · Wireshark-commits: [Wireshark-commits] master-2.0 5e769fc: cmake: Detect proper large file defines even with -Wno-error

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e769fc747813133f8a25a169af8dee094325963
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

5e769fc by Balint Reczey (balint@xxxxxxxxxxxxxxx):

    cmake: Detect proper large file defines even with -Wno-error
    
    Without this change large file support was detected as available
    even when it was not without additional flags on 32 architectures.
    
    As a result mergecap and other programs are built without large
    file support causing mergecap not being able to write files
    bigger than 2GB on i386 systems. This used to work properly
    with autotools builds, but not with CMake ones.
    
    Change-Id: Ibfd043342b2a48310d2ac9d760e6404a701c5808
    Reviewed-on: https://code.wireshark.org/review/15937
    Petri-Dish: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    (cherry picked from commit f749a64280051663f04fa5dfd11a50e3d4ce4e77)
    Reviewed-on: https://code.wireshark.org/review/16839
    

Actions performed:

    from  0d08650   gtk: Fix null dereference in stats
    adds  5e769fc   cmake: Detect proper large file defines even with -Wno-error


Summary of changes:
 cmake/TestFileOffsetBits.c     |    8 +++++++-
 cmake/TestLargeFiles.c.cmakein |   15 ++++++++++++---
 2 files changed, 19 insertions(+), 4 deletions(-)