Wireshark-commits: [Wireshark-commits] master-2.0 044ad5c: proto.c: do not perform bound checks in
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 Jul 2016 19:57:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=044ad5c3f362029f3d970bf88f721fee9f6e7f04
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

044ad5c by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    proto.c: do not perform bound checks in proto_tree_add_text(_valist)_internal if tvb is NULL
    
    As seen in bug 12676, some buggy dissectors do not systematically provide a tvb when calling proto_tree_add_XXX functions.
    On stable branch, let's deactivate the bound checks in that case.
    
    Bug: 12676
    Change-Id: Ia3cf0b0972c127f34feca2e097e0ec1fd1753b23
    Reviewed-on: https://code.wireshark.org/review/16752
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 8c7ab5f2b2c18f23c1baa856e30ff8dcb0b7151c)
    Reviewed-on: https://code.wireshark.org/review/16756
    

Actions performed:

    from  e38b602   Fix build on NetBSD.
    adds  044ad5c   proto.c: do not perform bound checks in proto_tree_add_text(_valist)_internal if tvb is NULL


Summary of changes:
 epan/proto.c |   28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)