Wireshark-commits: [Wireshark-commits] master-2.2 8a55b2d: WAP: check that tvb_get_guintvar does no
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 26 Jul 2016 08:17:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a55b2daa7cde40b2c6c94255e1fd7c2a6e239ce
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

8a55b2d by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    WAP: check that tvb_get_guintvar does not overflow
    
    Bug: 12661
    Change-Id: I2ef857d6be6595fd89f3dbb8d41c1c70d550ad93
    Reviewed-on: https://code.wireshark.org/review/16665
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 2193bea3212d74e2a907152055e27d409b59485e)
    Reviewed-on: https://code.wireshark.org/review/16683
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    

Actions performed:

    from  7583a2c   proto.c: add bounds check to proto_tree_add_text(_valist)_internal
    adds  8a55b2d   WAP: check that tvb_get_guintvar does not overflow


Summary of changes:
 epan/dissectors/packet-mmse.c  |   59 +++++++++++-------
 epan/dissectors/packet-wap.c   |    6 +-
 epan/dissectors/packet-wap.h   |    3 +-
 epan/dissectors/packet-wbxml.c |  132 ++++++++++++++++++++--------------------
 epan/dissectors/packet-wsp.c   |   56 +++++++++--------
 5 files changed, 139 insertions(+), 117 deletions(-)