Wireshark-commits: [Wireshark-commits] master 1da1f94: Fix checkAPI.pl warnings about printf
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1da1f945e2988080add4923dc2021753e3b2f7c1
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
1da1f94 by Michael Mann (mmann78@xxxxxxxxxxxx):
Fix checkAPI.pl warnings about printf
Many of the complaints from checkAPI.pl for use of printf are when its embedded
in an #ifdef and checkAPI isn't smart enough to figure that out.
The other (non-ifdef) use is dumping internal structures (which is a type of
debug functionality)
Add a "ws_debug_printf" macro for printf to pacify the warnings.
Change-Id: I63610e1adbbaf2feffb4ec9d4f817247d833f7fd
Reviewed-on: https://code.wireshark.org/review/16623
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from ee7f9c3 Pacify GTK checkAPIs.pl warnings.
adds 1da1f94 Fix checkAPI.pl warnings about printf
Summary of changes:
epan/asn1.c | 3 +-
epan/column.c | 5 +-
epan/dfilter/dfilter-macro.c | 61 +++++++++---------
epan/dfilter/dfilter.c | 8 ++-
epan/dfilter/gencode.c | 2 +-
epan/dfilter/semcheck.c | 8 ++-
epan/dissectors/packet-beep.c | 7 +-
epan/dissectors/packet-ber.c | 69 ++++++++++----------
epan/dissectors/packet-giop.c | 111 ++++++++++++++++----------------
epan/dissectors/packet-tacacs.c | 21 +++---
epan/dissectors/packet-wtp.c | 4 +-
epan/except.c | 15 +++--
epan/packet.c | 21 +++---
epan/proto.c | 33 +++++-----
epan/reedsolomon.c | 9 +--
epan/tvbuff_zlib.c | 9 ++-
epan/wslua/init_wslua.c | 3 +-
epan/wslua/wslua_internals.c | 5 +-
plugins/wimaxasncp/packet-wimaxasncp.c | 3 +-
ws_version_info.c | 3 +-
wsutil/plugins.c | 3 +-
wsutil/sha1.c | 17 ++---
wsutil/ws_printf.h | 8 +++
23 files changed, 234 insertions(+), 194 deletions(-)
