Wireshark-commits: [Wireshark-commits] master-2.0 7a1d292: Qt: Set the LabelStack CSS only when it
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 21 Jul 2016 19:48:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a1d292b17c504b94d68dccce76d544e46f4b7d9
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

7a1d292 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Set the LabelStack CSS only when it changes.
    
    We call fillLabel repeatedly while loading a capture. Try to avoid
    applying a style sheet when we do since it can affect performance.
    
    Change-Id: I9ee188cb79f7cad340ba35b12011b82004ed8262
    Reviewed-on: https://code.wireshark.org/review/16571
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 97d194cd3cb7fa3806a7bb83f83f06ee2eda418b)
    Reviewed-on: https://code.wireshark.org/review/16572
    

Actions performed:

    from  4dd230e   Qt UI: don't crash after following an SSL stream.
    adds  7a1d292   Qt: Set the LabelStack CSS only when it changes.


Summary of changes:
 ui/qt/label_stack.cpp |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)