Wireshark-commits: [Wireshark-commits] master ad6fc87: Add proto_tree_add_checksum.
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 21 Jul 2016 12:35:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ad6fc87d64de30cdcdca18168a117d2ec24591da Submitter: Michael Mann (mmann78@xxxxxxxxxxxx) Changed: branch: master Repository: wireshark Commits: ad6fc87 by Michael Mann (mmann78@xxxxxxxxxxxx): Add proto_tree_add_checksum. This is an attempt to standardize display/handling of checksum fields for all dissectors. The main target is for dissectors that do validation, but dissectors that just report the checksum were also included just to make them easier to find in the future. Bug: 10620 Bug: 12058 Ping-Bug: 8859 Change-Id: Ia8abd86e42eaf8ed50de6b173409e914b17993bf Reviewed-on: https://code.wireshark.org/review/16380 Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx> Actions performed: from 1e19f55 Constify a few value_strings which were generated at run-time adds ad6fc87 Add proto_tree_add_checksum. Summary of changes: colorfilters | 2 +- debian/libwireshark0.symbols | 1 + doc/README.dissector | 3 +- docbook/release-notes.asciidoc | 7 ++ epan/dissectors/asn1/c1222/packet-c1222-template.c | 24 ++-- epan/dissectors/packet-6lowpan.c | 3 +- epan/dissectors/packet-aol.c | 2 +- epan/dissectors/packet-artnet.c | 3 +- epan/dissectors/packet-asap.c | 5 +- epan/dissectors/packet-atalk.c | 102 +++++----------- epan/dissectors/packet-ax25-kiss.c | 12 +- epan/dissectors/packet-bitcoin.c | 2 +- epan/dissectors/packet-btatt.c | 2 +- epan/dissectors/packet-c1222.c | 28 ++--- epan/dissectors/packet-carp.c | 14 +-- epan/dissectors/packet-cattp.c | 29 ++--- epan/dissectors/packet-cdp.c | 70 +++-------- epan/dissectors/packet-cfdp.c | 2 +- epan/dissectors/packet-clnp.c | 48 +++----- epan/dissectors/packet-dccp.c | 36 ++---- epan/dissectors/packet-dec-dnart.c | 20 ++- epan/dissectors/packet-dji-uav.c | 3 +- epan/dissectors/packet-dmp.c | 56 +++------ epan/dissectors/packet-dmx.c | 48 +------- epan/dissectors/packet-dvb-s2-bb.c | 12 +- epan/dissectors/packet-dvmrp.c | 12 +- epan/dissectors/packet-eigrp.c | 17 +-- epan/dissectors/packet-epon.c | 12 +- epan/dissectors/packet-esis.c | 37 ++---- epan/dissectors/packet-eth.c | 57 ++------- epan/dissectors/packet-extreme.c | 49 ++------ epan/dissectors/packet-fc.c | 46 ++----- epan/dissectors/packet-fcoe.c | 42 +------ epan/dissectors/packet-fcoib.c | 42 +------ epan/dissectors/packet-fcswils.c | 2 +- epan/dissectors/packet-fefd.c | 41 +++---- epan/dissectors/packet-foundry.c | 2 +- epan/dissectors/packet-gdb.c | 3 +- epan/dissectors/packet-gfp.c | 76 +++--------- epan/dissectors/packet-gre.c | 18 +-- epan/dissectors/packet-h223.c | 16 +-- epan/dissectors/packet-hartip.c | 2 +- epan/dissectors/packet-hip.c | 32 ++--- epan/dissectors/packet-homeplug-av.c | 8 +- epan/dissectors/packet-icmp.c | 68 +++-------- epan/dissectors/packet-icmpv6.c | 75 +++++------- epan/dissectors/packet-idp.c | 2 +- epan/dissectors/packet-ieee80211.c | 57 ++------- epan/dissectors/packet-igap.c | 10 +- epan/dissectors/packet-igmp.c | 43 +++---- epan/dissectors/packet-igmp.h | 2 +- epan/dissectors/packet-igrp.c | 2 +- epan/dissectors/packet-ip.c | 90 ++++---------- epan/dissectors/packet-ipv6.c | 4 +- epan/dissectors/packet-ipx.c | 2 +- epan/dissectors/packet-isis-hello.c | 31 ++--- epan/dissectors/packet-isis-lsp.c | 70 +++-------- epan/dissectors/packet-isis-snp.c | 27 ++--- epan/dissectors/packet-itdm.c | 4 +- epan/dissectors/packet-kingfisher.c | 8 +- epan/dissectors/packet-lapd.c | 41 ++----- epan/dissectors/packet-lmp.c | 19 +-- epan/dissectors/packet-manolito.c | 4 +- epan/dissectors/packet-mbtcp.c | 13 +- epan/dissectors/packet-mip6.c | 4 +- epan/dissectors/packet-mpeg-dsmcc.c | 4 +- epan/dissectors/packet-mpeg-sect.c | 35 ++---- epan/dissectors/packet-mrdisc.c | 12 +- epan/dissectors/packet-msnip.c | 14 +-- epan/dissectors/packet-mstp.c | 97 +++------------ epan/dissectors/packet-mswsp.c | 3 +- epan/dissectors/packet-mtp2.c | 16 +-- epan/dissectors/packet-netsync.c | 4 +- epan/dissectors/packet-nhrp.c | 27 +---- epan/dissectors/packet-nlsp.c | 8 +- epan/dissectors/packet-nsrp.c | 4 +- epan/dissectors/packet-osi.c | 71 ++++------- epan/dissectors/packet-osi.h | 15 +-- epan/dissectors/packet-ositp.c | 61 ++++------ epan/dissectors/packet-ospf.c | 2 +- epan/dissectors/packet-pgm.c | 28 ++--- epan/dissectors/packet-pim.c | 37 +++--- epan/dissectors/packet-ppp.c | 29 +---- epan/dissectors/packet-quake2.c | 5 +- epan/dissectors/packet-rdm.c | 48 ++------ epan/dissectors/packet-rfid-pn532-hci.c | 6 +- epan/dissectors/packet-rgmp.c | 10 +- epan/dissectors/packet-rohc.c | 4 +- epan/dissectors/packet-roofnet.c | 4 +- epan/dissectors/packet-rtp-midi.c | 12 +- epan/dissectors/packet-rtps.c | 4 +- epan/dissectors/packet-rudp.c | 2 +- epan/dissectors/packet-s7comm.c | 2 +- epan/dissectors/packet-sbus.c | 31 ++--- epan/dissectors/packet-sctp.c | 68 ++++------- ... 33 lines suppressed ...
- Prev by Date: [Wireshark-commits] master 1e19f55: Constify a few value_strings which were generated at run-time
- Next by Date: [Wireshark-commits] master 97d194c: Qt: Set the LabelStack CSS only when it changes.
- Previous by thread: [Wireshark-commits] master 1e19f55: Constify a few value_strings which were generated at run-time
- Next by thread: [Wireshark-commits] master 97d194c: Qt: Set the LabelStack CSS only when it changes.
- Index(es):