Wireshark · Wireshark-commits: [Wireshark-commits] master 3beab65: No need to check for string option values being null.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3beab65515ab693806a7b64665bfd287133e860e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3beab65 by Guy Harris (guy@xxxxxxxxxxxx):

    No need to check for string option values being null.
    
    A string option, if present, always has a value; it might be a null
    *string*, but you won't get a null pointer (if the option isn't present,
    it simply isn't present).
    
    Fix some comments while we're at it.
    
    Change-Id: I9c1420f56998a7d04de5c5cc2e92631b181f303a
    Reviewed-on: https://code.wireshark.org/review/16564
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  be1398c   Convert uses of g_alloced data with tvb_new_child_real_data to use pinfo->pool instead.
    adds  3beab65   No need to check for string option values being null.


Summary of changes:
 capinfos.c                               |   19 +++++++------------
 cfile.c                                  |    6 ++----
 editcap.c                                |    3 +--
 epan/wslua/wslua.h                       |    4 ++--
 file.c                                   |    8 +++-----
 tshark.c                                 |    3 +--
 ui/gtk/summary_dlg.c                     |   16 ++++++++--------
 ui/qt/capture_file_properties_dialog.cpp |    6 +++---
 wiretap/merge.c                          |    2 +-
 9 files changed, 28 insertions(+), 39 deletions(-)