Wireshark-commits: [Wireshark-commits] master e5fa40a: Mark the file as having unsaved data if you
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 Jul 2016 23:05:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e5fa40ab31fd127b4ad005448b6676fe9517a755
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e5fa40a by Guy Harris (guy@xxxxxxxxxxxx):

    Mark the file as having unsaved data if you change address resolution.
    
    That information can, and will, get saved in some file formats, so mark
    the file as changed so it can and will get saved by "Save".
    
    XXX - we need to treat it as a type of data that can be discarded when
    saving in some file formats, just like comments.
    
    Bug: 12629
    Change-Id: I1fd69b95f4f7345c339961b4c53c28b98b364e4e
    Reviewed-on: https://code.wireshark.org/review/16538
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6df8e83   block->options is never null; don't check for it.
    adds  e5fa40a   Mark the file as having unsaved data if you change address resolution.


Summary of changes:
 file.c                         |   18 ++++++++++++++++++
 file.h                         |   10 ++++++++++
 ui/gtk/manual_addr_resolv.c    |    3 ++-
 ui/qt/address_editor_frame.cpp |   29 ++++++++++++++++-------------
 ui/qt/address_editor_frame.h   |    1 +
 5 files changed, 47 insertions(+), 14 deletions(-)