Wireshark-commits: [Wireshark-commits] master 468a5e2: Use follow_record_t in SSL follow stream.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 Jul 2016 10:43:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=468a5e27255190cc7cfa2e52a2b54578dcb9e1d8
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

468a5e2 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Use follow_record_t in SSL follow stream.
    
    ... rather than a structure (SslDecryptedRecord) which looks (mostly) like a
    follow_record_t.  (The biggest different is the former carries its data in a
    StringInfo while the latter uses a GByteArray.)
    
    With this change following SSL no longer needs its own special code.
    
    This also fixes a crash after saving a followed SSL stream (in the Qt UI).
    
    Bug: 12616
    Change-Id: Ibdb2b85f8a6a30712743a5da420be1e6b78f5b92
    Reviewed-on: https://code.wireshark.org/review/16516
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  752ba1a   packet-smb2: add dissectors for FSCTL_GET_REPARSE_POINT/FSCTL_SET_REPARSE_POINT
    adds  468a5e2   Use follow_record_t in SSL follow stream.


Summary of changes:
 epan/dissectors/packet-ssl-utils.h |    6 ---
 epan/dissectors/packet-ssl.c       |   24 +++++++-----
 ui/gtk/follow_stream.c             |   63 +------------------------------
 ui/qt/follow_stream_dialog.cpp     |   72 +-----------------------------------
 4 files changed, 16 insertions(+), 149 deletions(-)