Wireshark-commits: [Wireshark-commits] master 1a3fc2e: IPv6: Remove union from struct ip6_hdr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 Jul 2016 01:32:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a3fc2e7af060cd41a22ee9774507871d7fcc72f
Submitter: João Valverde (j@xxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1a3fc2e by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    IPv6: Remove union from struct ip6_hdr
    
    The field macros are a particularly obnoxious form of namespace pollution.
    
    Change-Id: I9010a767625fd1c4b4a48c9d75481c577915fce6
    Reviewed-on: https://code.wireshark.org/review/16520
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  5123fa2   L2TP: Add dissectors for Ericsson specific L2TP AVPs
    adds  1a3fc2e   IPv6: Remove union from struct ip6_hdr


Summary of changes:
 epan/dissectors/packet-6lowpan.c |   62 ++++++++++++++++++++------------------
 epan/dissectors/packet-ipv6.c    |   32 ++++++++++++--------
 epan/dissectors/packet-ipv6.h    |   25 +++++----------
 3 files changed, 59 insertions(+), 60 deletions(-)