Wireshark-commits: [Wireshark-commits] master 29cecf2: Qt: Reserve packet list model vectors.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 15 Jul 2016 19:34:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29cecf27c438cb2a1203ee5d877cb38566c977ee
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

29cecf2 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Reserve packet list model vectors.
    
    Preallocate and hold onto the data in the various packet list model
    vectors. I'm not sure how much this will affect performance, but the
    documentation suggests that it's the right thing to do in our case.
    
    Change-Id: If2d5ad142bf2d61e0bc2302990bd288274447df5
    Reviewed-on: https://code.wireshark.org/review/16475
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  d0af229   Squelch a compiler warning.
    adds  29cecf2   Qt: Reserve packet list model vectors.


Summary of changes:
 ui/qt/packet_list_model.cpp |   22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)