Wireshark-commits: [Wireshark-commits] master d5e435e: DHCP: correctly parse PXE options (209-210)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 14 Jul 2016 14:55:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d5e435eb01a215aac466e017f46fba5007667158
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d5e435e by Daniele Lacamera (daniele.lacamera@xxxxxxxxxxxxxxx):

    DHCP: correctly parse PXE options (209-210)
    
    option 209 was marked as opaque, now it's  as PXELINUX config file (text)
    --> Fix: decorate as non-null terminated string
    --> CfR: IETF RFC5071 section 4.2. "Packet Format"
    
    option 210 was marked as special, and erroneously decorated as Authentication
    (option 90)
    --> Fix: decorate as non-null terminated string
    --> CfR: IETF RFC5071 section 5.2. "Packet Format"
    
    Bug: 12618
    Change-Id: I4220c137ef4b8b7f0827496c165b0ca35b70f675
    Reviewed-on: https://code.wireshark.org/review/16430
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  644c009   ETAG: add explicit casts to please OSX buildbot
    adds  d5e435e   DHCP: correctly parse PXE options (209-210)


Summary of changes:
 epan/dissectors/packet-bootp.c |   17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)