Wireshark-commits: [Wireshark-commits] master 998ab7f: Speed up col_append_ports on Windows.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 Jul 2016 22:23:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=998ab7f7e5fba959b5451c8ac95a1a87acfbd9b4
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

998ab7f by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Speed up col_append_ports on Windows.
    
    Fill in our port information using StringCchPrintf on Windows instead
    of g_snprintf. Loading a large-ish test capture here under the VS 2013
    profiler showed that we spent 620 samples in col_append_ports. Switching
    from g_snprintf to StringCchPrintf reduced that to six samples.
    
    Inline col_snprint_port while we're here.
    
    Change-Id: I955e5baa66ebb9cc950fc0eb1682d3c015c7a55a
    Reviewed-on: https://code.wireshark.org/review/16416
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  1bd438b   Adding 802.1BR E-Tag dissector
    adds  998ab7f   Speed up col_append_ports on Windows.


Summary of changes:
 epan/column-utils.c |   24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)