Wireshark-commits: [Wireshark-commits] master-1.12 ebaa83e: Remove T.30 FCF mask.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 Jul 2016 19:33:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ebaa83e22ee8bab315169f32d2aa276ec1edb6ca
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

ebaa83e by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove T.30 FCF mask.
    
    Found by VS Code Analysis, verified with spec that mask isn't needed.
    Also included link to current spec.
    
    Bug: 1918
    Change-Id: Ic3e8ee599501c7c12717649579ffd70581622178
    Reviewed-on: https://code.wireshark.org/review/16392
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit e063924a02a06b1d0084b6aa584a3785d6e026b8)
    Reviewed-on: https://code.wireshark.org/review/16401
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    (cherry picked from commit 7780d3d12c5a341ac2b7da312719e05fd796bb3f)
    Reviewed-on: https://code.wireshark.org/review/16403
    

Actions performed:

    from  e8a2201   Fixing picosecond timestamp for vrt protocol.  Needs to be parsed as uint64 not double
    adds  ebaa83e   Remove T.30 FCF mask.


Summary of changes:
 epan/dissectors/packet-t30.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)