Wireshark-commits: [Wireshark-commits] master ee28324: Fix up *some* of the coding style inconsiste
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 11 Jul 2016 17:19:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee28324d54750f14b0e53a96695cc0dd26bbab77
Submitter: J?rg Mayer (jmayer@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ee28324 by Joerg Mayer (jmayer@xxxxxxxxx):

    Fix up *some* of the coding style inconsistencies
    
    - return type of a function definition is always on a seperate line
    - reformat single line expert items into multiline format
    - no space between functionname and (
    - reformat some hf_ elements that looked different from most others
    - space after , where appropriate
    - Fix the following warnings and errors from checkhf.pl
      Unused href entry: epan/dissectors/packet-ieee80211.c: hf_ieee80211_ff_rcsi
      Unused href entry: epan/dissectors/packet-ieee80211.c: hf_ieee80211_ff_rcsi_aid
      Error: hf_ieee80211_ff_dsss_ofdm: FT_BOOLEAN with non-null 'convert' field missing TFS in epan/dissectors/packet-ieee80211.c
      Error: non-null hf_ieee80211_ff_dsss_ofdm 'convert' field missing 'VALS|VALS64|RVALS|TFS|CF_FUNC|FRAMENUM_TYPE|&' in epan/dissectors/packet-ieee80211.c ?
      Error: hf_ieee80211_operat_mode_field_channel_width is passing the address of a pointer to VALS in epan/dissectors/packet-ieee80211.c
      Error: hf_ieee80211_operat_mode_field_rxnss is passing the address of a pointer to VALS in epan/dissectors/packet-ieee80211.c
    
    Change-Id: Ide51d1871755199721e65c0f62b3f6a62ef1159e
    Reviewed-on: https://code.wireshark.org/review/16381
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    

Actions performed:

    from  7083839   IPv6: refactor dissect_routing6() into type-specific dissectors
    adds  ee28324   Fix up *some* of the coding style inconsistencies


Summary of changes:
 epan/dissectors/packet-ieee80211.c | 1318 +++++++++++++++++++-----------------
 1 file changed, 713 insertions(+), 605 deletions(-)