Wireshark-commits: [Wireshark-commits] master c3fc1e4: APRS: more cleanup.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 8 Jul 2016 11:05:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c3fc1e41c8ca20eeacd1c863d4e0d94e1e76e67e
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c3fc1e4 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    APRS: more cleanup.
    
    There's no need to create global structures with pointers to the (global) hf's
    to pass into the dissection functions.  Just reference the global variables
    directly.
    
    Remove other global variables passed as arguments while we're at it.
    
    Remove boilerplate comments.
    
    Change-Id: I7ce6b356172aa25983f4cc6a007a0158cb7f26c9
    Reviewed-on: https://code.wireshark.org/review/16331
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  54bf3e9   APRS: clean up some header fields.
    adds  c3fc1e4   APRS: more cleanup.


Summary of changes:
 epan/dissectors/packet-aprs.c |  320 ++++++++++-------------------------------
 1 file changed, 75 insertions(+), 245 deletions(-)