Wireshark-commits: [Wireshark-commits] master 166cede: APRS: register the storm fields.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 7 Jul 2016 10:51:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=166cedefbeb230a2f22106740fe34b34fc410d4c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

166cede by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    APRS: register the storm fields.
    
    There's been a comment here since 2012 about them being unregistered.  Put in
    some registrations based on a feeble understanding of the specification (these
    are all strings, add them as such); that should be close enough and is much
    better than the (dissector) assertion we'd get otherwise.
    
    Don't bother putting those hf's in a global structure and passing around the
    structure: the hf's are global anyway--just reference them directly.
    
    Add a link to the specification while we're here.
    
    Change-Id: Ia7b17e92a996a1a8eb4a4489eff9fca042190a32
    Reviewed-on: https://code.wireshark.org/review/16318
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  fb74b16   PAPI: Update Header field
    adds  166cede   APRS: register the storm fields.


Summary of changes:
 epan/dissectors/packet-aprs.c |   96 ++++++++++++++++++++++++-----------------
 1 file changed, 57 insertions(+), 39 deletions(-)