Wireshark-commits: [Wireshark-commits] master 5758aa5: ATM PW: don't use macros to generate hf entr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 6 Jul 2016 11:07:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5758aa541dc0641879fa5fa475c9be7a16da0bdf
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5758aa5 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    ATM PW: don't use macros to generate hf entries.
    
    The macros weren't saving much code, were confusing checkhf.pl, and were hiding
    useability problems with the fields (such as names equal to the abbreviation
    and having several fields with the same abbreviation--things checkAPIs.pl can
    check now that the macros are out of the way).
    
    Change-Id: Id2ba67d09ce7dd424aee9d7f2e25eb54fa432d98
    Reviewed-on: https://code.wireshark.org/review/16315
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  7f22c8a   LAT: use ENC_ASCII when adding strings.
    adds  5758aa5   ATM PW: don't use macros to generate hf entries.


Summary of changes:
 epan/dissectors/packet-pw-atm.c |   47 ++++++++++++++++++++++-----------------
 1 file changed, 27 insertions(+), 20 deletions(-)