Wireshark-commits: [Wireshark-commits] master 5848845: Qt: remove unneeded constructors.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 6 Jul 2016 05:19:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5848845c34425aa21f4e136049f95b37214df841
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5848845 by Dario Lombardo (lomato@xxxxxxxxx):

    Qt: remove unneeded constructors.
    
    There is no need to have an empty private constructor if an explicit
    one is already present. The former private constructor didn't initialize
    the private members causing many CIDs from coverity.
    
    Change-Id: I8ba98d2b9fc32a867fdcf3421df7946b90bd7b09
    Reviewed-on: https://code.wireshark.org/review/16311
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  21f5c53   Rename PIDL Makefile
    adds  5848845   Qt: remove unneeded constructors.


Summary of changes:
 ui/qt/lbm_lbtrm_transport_dialog.cpp |    4 ----
 ui/qt/lbm_lbtru_transport_dialog.cpp |    5 -----
 2 files changed, 9 deletions(-)