Wireshark-commits: [Wireshark-commits] master 38c6a59: Add length checks.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 4 Jul 2016 21:15:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=38c6a591580e57def08858d6e525c8887e6a9fa3
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

38c6a59 by Guy Harris (guy@xxxxxxxxxxxx):

    Add length checks.
    
    Make sure the authentication trailer length is large enough for a
    minimum-length authentication trailer.
    
    Hopefully this fixes the real problem reported by CID 1363027.
    
    Use proto_tree_add_item_ret_uint() while we're at it.
    
    Change-Id: I3377f2a52a26f00eeb24ee5776853ffc6e4f7cce
    Reviewed-on: https://code.wireshark.org/review/16295
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6b5d839   Check to make sure the name length <= DLM3_RESNAME_MAXLEN.
    adds  38c6a59   Add length checks.


Summary of changes:
 epan/dissectors/packet-ospf.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)