Wireshark-commits: [Wireshark-commits] master 276db50: Add length checks.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 4 Jul 2016 20:41:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=276db500154eb7066237af0edd2fa26d7e2b9d71
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

276db50 by Guy Harris (guy@xxxxxxxxxxxx):

    Add length checks.
    
    While scanning through the Prefix64 option, check to make sure we
    haven't run past the end of the option.
    
    The Prefix64 option requires that the prefix length be <= 12, and, if
    it's not, we end up with part of the prefix having a negative length.
    Check to make sure that it is <= 12.
    
    While we're at it, use proto_tree_add_item_ret_uint(), update IETF
    document references to use RFCs rather tha earlier I-Ds, and add
    references for RFC 7220 and RFC 7225.
    
    Hopefully this fixes the *real* problem that CID 1363032 was complaining
    about.
    
    Change-Id: I1592de31f1d4f4ed6e6cdc141516fb764f21d2fb
    Reviewed-on: https://code.wireshark.org/review/16287
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  af35e89   .mailmap: Update some name...
    adds  276db50   Add length checks.


Summary of changes:
 epan/dissectors/packet-nat-pmp.c |   82 +++++++++++++++++++++++++++-----------
 1 file changed, 58 insertions(+), 24 deletions(-)