Wireshark · Wireshark-commits: [Wireshark-commits] master 2da35bc: profinet, CID 1362120: check the return value of ftell()

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2da35bce9a3e4a18a9fa251eadb76a3a3695e726
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2da35bc by Martin Kaiser (wireshark@xxxxxxxxx):

    profinet, CID 1362120: check the return value of ftell()
    
    change filePosRecord's data type to long, this is what ftell() and
    fseek() expect
    
    limit filePosRecord's scope to the block where it's actually used
    
    if ftell() returns < 0, don't move the file pointer and don't call
    fseek() with the negative offset
    
    Change-Id: If5a43099c32e476a691f4d6cd26ed7fb73490fcf
    Reviewed-on: https://code.wireshark.org/review/16258
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  50614a9   checkhf: Use colon as field separator for better readability
    adds  2da35bc   profinet, CID 1362120: check the return value of ftell()


Summary of changes:
 plugins/profinet/packet-dcerpc-pn-io.c |   25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)