Wireshark-commits: [Wireshark-commits] master-2.0 20ac0e1: proto.c: allow calling get_hfi_length()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 2 Jul 2016 07:58:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=20ac0e1e6d53863f28340217aa1ca915bf23f679
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

20ac0e1 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    proto.c: allow calling get_hfi_length() with a 0 byte tvb and length=-1
    
    As indicated in the comment, we allow FT_PROTOCOL, FT_NONE, FT_BYTES, FT_STRING
    and FT_STRINGZPAD to be zero-length.
    But in that case do not call tvb_ensure_captured_length_remaining() that ensures
    that at least 1 byte is  present.
    
    Bug: 12561
    Change-Id: I881754368c24d334b88f0dda1d59a68e08219227
    Reviewed-on: https://code.wireshark.org/review/16167
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit b78dd096f40adef2ffd0ddd4ef8aee1ea7ca54e6)
    Reviewed-on: https://code.wireshark.org/review/16240
    

Actions performed:

    from  0fcd23c   BGP dissector: Fixing NLRI length for flow spec NLRI
    adds  20ac0e1   proto.c: allow calling get_hfi_length() with a 0 byte tvb and length=-1


Summary of changes:
 epan/proto.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)