Wireshark-commits: [Wireshark-commits] master a062c80: ASN.1 dissectors - don't try to find yoursel
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 1 Jul 2016 14:26:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a062c802364fd83d43f934560149f2ddd1fee6a3 Submitter: Anders Broman (a.broman58@xxxxxxxxx) Changed: branch: master Repository: wireshark Commits: a062c80 by Michael Mann (mmann78@xxxxxxxxxxxx): ASN.1 dissectors - don't try to find yourself. If an ASN.1 dissector is calling register_dissector for itself in its proto_register_xxx function and then calling find_dissector for itself in its proto_reg_handoff_xxx function then just create a static handle for that dissector and use the return value of register_dissector, so the find isn't necessary. Change-Id: I911bdadc2fb4259601c141b955e741a2369cc447 Reviewed-on: https://code.wireshark.org/review/16233 Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx> Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx> Actions performed: from d4add25 s7comm: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang adds a062c80 ASN.1 dissectors - don't try to find yourself. Summary of changes: epan/dissectors/asn1/acse/packet-acse-template.c | 6 +++--- .../asn1/ansi_map/packet-ansi_map-template.c | 3 +-- epan/dissectors/asn1/camel/packet-camel-template.c | 10 +++------ epan/dissectors/asn1/cmip/packet-cmip-template.c | 6 +++--- epan/dissectors/asn1/disp/packet-disp-template.c | 9 +++----- epan/dissectors/asn1/dsp/packet-dsp-template.c | 7 +++---- epan/dissectors/asn1/goose/packet-goose-template.c | 7 +++---- .../asn1/gsm_map/packet-gsm_map-template.c | 3 +-- epan/dissectors/asn1/h225/packet-h225-template.c | 7 ++++--- epan/dissectors/asn1/h245/packet-h245-template.c | 9 +++----- epan/dissectors/asn1/h248/packet-h248-template.c | 6 ++---- epan/dissectors/asn1/h283/packet-h283-template.c | 7 +++---- epan/dissectors/asn1/h501/packet-h501-template.c | 3 +-- epan/dissectors/asn1/hnbap/packet-hnbap-template.c | 6 +++--- epan/dissectors/asn1/idmp/packet-idmp-template.c | 5 +---- epan/dissectors/asn1/ilp/packet-ilp-template.c | 6 +++--- epan/dissectors/asn1/inap/packet-inap-template.c | 3 +-- epan/dissectors/asn1/lcsap/packet-lcsap-template.c | 6 +++--- epan/dissectors/asn1/ldap/packet-ldap-template.c | 3 +-- .../asn1/mpeg-pes/packet-mpeg-pes-template.c | 5 ++--- epan/dissectors/asn1/nbap/packet-nbap-template.c | 7 +++---- epan/dissectors/asn1/p1/packet-p1-template.c | 8 +++---- epan/dissectors/asn1/pcap/packet-pcap-template.c | 3 +-- epan/dissectors/asn1/ranap/packet-ranap-template.c | 7 ++++--- epan/dissectors/asn1/rnsap/packet-rnsap-template.c | 7 +++---- epan/dissectors/asn1/ros/packet-ros-template.c | 4 +--- epan/dissectors/asn1/rua/packet-rua-template.c | 6 +++--- epan/dissectors/asn1/s1ap/packet-s1ap-template.c | 6 +++--- epan/dissectors/asn1/sabp/packet-sabp-template.c | 12 +++++------ epan/dissectors/asn1/snmp/packet-snmp-template.c | 4 +--- .../asn1/spnego/packet-spnego-template.c | 16 +++++++------- epan/dissectors/asn1/sv/packet-sv-template.c | 8 +++---- epan/dissectors/asn1/ulp/packet-ulp-template.c | 7 ++++--- epan/dissectors/asn1/x2ap/packet-x2ap-template.c | 6 +++--- epan/dissectors/packet-acse.c | 12 +++++------ epan/dissectors/packet-ansi_map.c | 7 +++---- epan/dissectors/packet-camel.c | 16 ++++++-------- epan/dissectors/packet-cmip.c | 18 ++++++++-------- epan/dissectors/packet-disp.c | 15 ++++++------- epan/dissectors/packet-dsp.c | 11 +++++----- epan/dissectors/packet-goose.c | 11 +++++----- epan/dissectors/packet-gsm_map.c | 9 ++++---- epan/dissectors/packet-h225.c | 17 ++++++++------- epan/dissectors/packet-h245.c | 21 ++++++++----------- epan/dissectors/packet-h248.c | 6 ++---- epan/dissectors/packet-h283.c | 13 ++++++------ epan/dissectors/packet-h501.c | 3 +-- epan/dissectors/packet-hnbap.c | 12 +++++------ epan/dissectors/packet-idmp.c | 5 +---- epan/dissectors/packet-ilp.c | 18 ++++++++-------- epan/dissectors/packet-inap.c | 7 +++---- epan/dissectors/packet-lcsap.c | 8 +++---- epan/dissectors/packet-ldap.c | 5 ++--- epan/dissectors/packet-mpeg-pes.c | 9 ++++---- epan/dissectors/packet-nbap.c | 15 +++++++------ epan/dissectors/packet-p1.c | 22 +++++++++----------- epan/dissectors/packet-pcap.c | 9 ++++---- epan/dissectors/packet-ranap.c | 15 ++++++------- epan/dissectors/packet-rnsap.c | 15 +++++++------ epan/dissectors/packet-ros.c | 4 +--- epan/dissectors/packet-rua.c | 12 +++++------ epan/dissectors/packet-s1ap.c | 8 +++---- epan/dissectors/packet-sabp.c | 20 ++++++++---------- epan/dissectors/packet-snmp.c | 4 +--- epan/dissectors/packet-spnego.c | 22 ++++++++++---------- epan/dissectors/packet-sv.c | 14 ++++++------- epan/dissectors/packet-ulp.c | 15 ++++++------- epan/dissectors/packet-x2ap.c | 12 +++++------ 68 files changed, 280 insertions(+), 348 deletions(-)
- Prev by Date: [Wireshark-commits] master d4add25: s7comm: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
- Next by Date: [Wireshark-commits] master ad30999: Cleanup LAPD preferences and registration handoff routine
- Previous by thread: [Wireshark-commits] master d4add25: s7comm: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
- Next by thread: [Wireshark-commits] master ad30999: Cleanup LAPD preferences and registration handoff routine
- Index(es):