Wireshark-commits: [Wireshark-commits] master 8c37621: CIP: Cleanup info column for MSP packets
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 27 Jun 2016 12:34:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8c37621ca733a24a972e3e069a537c06e650f435
Submitter: Jaap Keuter (jaap.keuter@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8c37621 by D. Ulis (daulis0@xxxxxxxxx):

    CIP: Cleanup info column for MSP packets
    
    1. Skip printing class name in info column when it was an MSP, since it's implied.
    2. Don't print response status for embedded messages in info column for MSP. It makes the line too long.
    3. Print the response status for embedded messages in the Service Packet tree. This makes it easier to find the packet that may have failed.
    
    Change-Id: I2c60fb9baf113a215ada7301f493cbd51e340dcd
    Reviewed-on: https://code.wireshark.org/review/16162
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  58ccf8e   endpoint dialog: fix compilation when we don't HAVE_GEOIP.
    adds  8c37621   CIP: Cleanup info column for MSP packets


Summary of changes:
 epan/dissectors/packet-cip.c |   21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)