Wireshark-commits: [Wireshark-commits] lts-1.12.1 024bf5d: UMTS_FP: fix handling reserved C/T value
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 24 Jun 2016 00:40:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=024bf5dfd68da67dd00475a5fea7cfabf03da8fa
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

024bf5d by Evan Huus (eapache@xxxxxxxxx):

    UMTS_FP: fix handling reserved C/T value
    
    The spec puts the reserved value at 0xf but our internal table has 'unknown' at
    0; since all the other values seem to be offset-by-one, just take the modulus
    0xf to avoid running off the end of the table.
    
    # Conflicts:
    #	epan/dissectors/packet-umts_fp.c
    
    Bug: 12191
    Change-Id: I83c8fb66797bbdee52a2246fb1eea6e37cbc7eb0
    Reviewed-on: https://code.wireshark.org/review/15722
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 7d7190695ce2ff269fdffb04e87139995cde21f4)
    Reviewed-on: https://code.wireshark.org/review/15726
    (cherry picked from commit fb9dcfa8e5df3ea3207335491b86be8cbb21eeaf)
    Reviewed-on: https://code.wireshark.org/review/16118
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  434fe44   WBXML: add a basic sanity check for offset overflow
    adds  024bf5d   UMTS_FP: fix handling reserved C/T value


Summary of changes:
 epan/dissectors/packet-umts_fp.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)