Wireshark-commits: [Wireshark-commits] master 300e055: Qt: Use queued signals+slots for filter acti
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=300e055ab6e3ede51de2258c83d9aeab4b7f3701
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
300e055 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Qt: Use queued signals+slots for filter actions
Many of our dialogs can send an "apply this display filter" signal to
the main window. Applying a display filter in turn creates a nested
event loop via cf_read+update_progress_dlg. If the "apply" signal+slot
is directly connected (which is the default, and which means we're
calling into a function table) we can close the dialog while the signal
is firing, which means we return into a deleted object.
Make all of the filterAction signals+slots queued instead of direct.
Bug: 12523
Change-Id: Ica331054c0aa52a7f33bd8df1fa65ecd09fdc292
Reviewed-on: https://code.wireshark.org/review/16080
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 933c079 HTTP: Split URI into path and query. Tokenize parameters.
adds 300e055 Qt: Use queued signals+slots for filter actions
Summary of changes:
ui/qt/conversation_dialog.cpp | 8 ++++----
ui/qt/conversation_dialog.h | 2 +-
ui/qt/endpoint_dialog.cpp | 8 ++++----
ui/qt/expert_info_dialog.h | 2 +-
ui/qt/main_window.cpp | 6 ++++++
ui/qt/main_window.h | 3 ++-
ui/qt/main_window_slots.cpp | 41 +++++++++++++++++++------------------
ui/qt/protocol_hierarchy_dialog.h | 2 +-
ui/qt/tap_parameter_dialog.h | 2 +-
ui/qt/traffic_table_dialog.h | 4 ++--
10 files changed, 43 insertions(+), 35 deletions(-)
