Wireshark-commits: [Wireshark-commits] master 63027fc: Windows: rename wiretap-${PROJECT_VERSION}.d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 22 Jun 2016 23:57:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=63027fce6e11e645865607cf4124eb8cfb4c3609
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

63027fc by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Windows: rename wiretap-${PROJECT_VERSION}.dll to libwiretap.dll
    
    This aligns the name with what is done for other Wireshark shared libraries.
    Moreover it allows to compile a wiretap plugin once per major release, without
    the need to recompile it each time ${PROJECT_VERSION} changes (each nightly
    build / official release).
    
    Change-Id: I53c82277223a4f323079cf695168ac85c2fba523
    Reviewed-on: https://code.wireshark.org/review/16058
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  a9a306f   Don't close Wireshark (GTK) if user cancels Save on Close.
    adds  63027fc   Windows: rename wiretap-${PROJECT_VERSION}.dll to libwiretap.dll


Summary of changes:
 image/wiretap.rc.in               |    2 +-
 packaging/nsis/CMakeLists.txt     |    2 --
 packaging/nsis/config.nsh.in      |    1 -
 packaging/nsis/wireshark.nsi      |    2 +-
 packaging/wix/CMakeLists.txt      |    3 ---
 packaging/wix/ComponentGroups.wxi |    2 +-
 wiretap/CMakeLists.txt            |    4 +---
 7 files changed, 4 insertions(+), 12 deletions(-)