Wireshark-commits: [Wireshark-commits] master f9cf660: Qt: Fix crash in Conversations and Endpoints
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 22 Jun 2016 21:25:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f9cf660e6e4fc0e52e6ed7c14ebec4532586eb5e
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f9cf660 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fix crash in Conversations and Endpoints dialogs
    
    Don't assume that conv_item_t or hostlist_talker_t pointers never
    change. GArrays can reallocate their data, and in our case this can
    happen when we have more than 10,000 items (which is the size that the
    conversation table code passes to_array_sized_new).
    
    Bug: 12288
    Change-Id: I88e58be830e35dde272f81fe9250b054fb87facf
    Reviewed-on: https://code.wireshark.org/review/16078
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  692e2b6   SSH: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
    adds  f9cf660   Qt: Fix crash in Conversations and Endpoints dialogs


Summary of changes:
 ui/qt/conversation_dialog.cpp |   56 ++++++++++++++++++++++-------------------
 ui/qt/endpoint_dialog.cpp     |   55 ++++++++++++++++++++--------------------
 2 files changed, 58 insertions(+), 53 deletions(-)