Wireshark · Wireshark-commits: [Wireshark-commits] master a383e69: Revert "tap: change glib functions to wmem."

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a383e692c8774c2451a55d8b3f8ef9db5d037329
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a383e69 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Revert "tap: change glib functions to wmem."
    
    This reverts commit 2e9f3c5d366eaa7139fc877b5301392166b3f985.
    
    It breaks the registration of codec, dissector and libwiretap plugins.
    
    Change-Id: I4ef91dd192f765adf87ea9fe9f3693e25dbd24de
    Reviewed-on: https://code.wireshark.org/review/16012
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  ff84512   Add modelines
    adds  a383e69   Revert "tap: change glib functions to wmem."


Summary of changes:
 dftest.c                                 |    9 +++
 epan/dissectors/packet-smb-sidsnooping.c |   10 +--
 epan/dissectors/packet-smb.c             |    4 +-
 epan/dissectors/packet-smb2.c            |    4 +-
 epan/epan.c                              |   14 ----
 epan/tap.c                               |   48 ++++++------
 epan/tap.h                               |    8 +-
 epan/wslua/wslua_field.c                 |    6 +-
 epan/wslua/wslua_listener.c              |    6 +-
 plugins/mate/packet-mate.c               |    6 +-
 rawshark.c                               |    6 +-
 tfshark.c                                |   10 +++
 tshark.c                                 |    6 ++
 ui/cli/tap-camelsrt.c                    |    6 +-
 ui/cli/tap-comparestat.c                 |    6 +-
 ui/cli/tap-diameter-avp.c                |    6 +-
 ui/cli/tap-endpoints.c                   |    6 +-
 ui/cli/tap-expert.c                      |    6 +-
 ui/cli/tap-follow.c                      |    4 +-
 ui/cli/tap-gsm_astat.c                   |    4 +-
 ui/cli/tap-hosts.c                       |    6 +-
 ui/cli/tap-httpstat.c                    |    6 +-
 ui/cli/tap-icmpstat.c                    |    6 +-
 ui/cli/tap-icmpv6stat.c                  |    6 +-
 ui/cli/tap-iostat.c                      |    6 +-
 ui/cli/tap-iousers.c                     |    6 +-
 ui/cli/tap-macltestat.c                  |    4 +-
 ui/cli/tap-protocolinfo.c                |    6 +-
 ui/cli/tap-protohierstat.c               |    6 +-
 ui/cli/tap-rlcltestat.c                  |    4 +-
 ui/cli/tap-rpcprogs.c                    |    6 +-
 ui/cli/tap-rtd.c                         |    6 +-
 ui/cli/tap-rtp.c                         |    4 +-
 ui/cli/tap-rtspstat.c                    |    6 +-
 ui/cli/tap-sctpchunkstat.c               |    6 +-
 ui/cli/tap-simple_stattable.c            |    6 +-
 ui/cli/tap-sipstat.c                     |    6 +-
 ui/cli/tap-smbsids.c                     |    6 +-
 ui/cli/tap-srt.c                         |    6 +-
 ui/cli/tap-stats_tree.c                  |    5 +-
 ui/cli/tap-sv.c                          |    6 +-
 ui/cli/tap-wspstat.c                     |    6 +-
 ui/gtk/compare_stat.c                    |    6 +-
 ui/gtk/conversations_table.c             |   12 +--
 ui/gtk/dcerpc_stat.c                     |    6 +-
 ui/gtk/expert_comp_dlg.c                 |   20 ++---
 ui/gtk/export_object_dlg.c               |    6 +-
 ui/gtk/follow_stream.c                   |    5 +-
 ui/gtk/gsm_map_summary.c                 |    6 +-
 ui/gtk/hostlist_table.c                  |   12 +--
 ui/gtk/iax2_analysis.c                   |    6 +-
 ui/gtk/io_stat.c                         |    6 +-
 ui/gtk/lbm_stream_dlg.c                  |    6 +-
 ui/gtk/lbm_uimflow_dlg.c                 |    6 +-
 ui/gtk/mac_lte_stat_dlg.c                |    6 +-
 ui/gtk/main.c                            |    5 ++
 ui/gtk/mtp3_summary.c                    |    6 +-
 ui/gtk/response_time_delay_table.c       |    6 +-
 ui/gtk/rlc_lte_stat_dlg.c                |    6 +-
 ui/gtk/rpc_stat.c                        |    6 +-
 ui/gtk/rtp_analysis.c                    |    6 +-
 ui/gtk/sctp_chunk_stat.c                 |    6 +-
 ui/gtk/service_response_time_table.c     |    6 +-
 ui/gtk/simple_stattable.c                |    6 +-
 ui/gtk/stats_tree_stat.c                 |    6 +-
 ui/gtk/wlan_stat_dlg.c                   |   12 +--
 ui/mcast_stream.c                        |    8 +-
 ui/qt/bluetooth_device_dialog.cpp        |    6 +-
 ui/qt/bluetooth_hci_summary_dialog.cpp   |    6 +-
 ui/qt/expert_info_dialog.cpp             |    6 +-
 ui/qt/gsm_map_summary_dialog.cpp         |    6 +-
 ui/qt/io_graph_dialog.cpp                |   13 ++--
 ui/qt/lbm_lbtrm_transport_dialog.cpp     |    6 +-
 ui/qt/lbm_lbtru_transport_dialog.cpp     |    6 +-
 ui/qt/lbm_stream_dialog.cpp              |    6 +-
 ui/qt/mtp3_summary_dialog.cpp            |    6 +-
 ui/qt/wireshark_dialog.cpp               |    6 +-
 ui/rtp_stream.c                          |    6 +-
 ui/tap-rlc-graph.c                       |   12 +--
 ui/tap-sctp-analysis.c                   |    6 +-
 ui/tap-tcp-stream.c                      |   12 +--
 ui/tap_export_pdu.c                      |    8 +-
 ui/voip_calls.c                          |  120 +++++++++++++++---------------
 wireshark-qt.cpp                         |   20 ++---
 84 files changed, 377 insertions(+), 356 deletions(-)