Wireshark-commits: [Wireshark-commits] master 9b5b444: Refactor command-line handling of GUI option
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Jun 2016 05:57:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9b5b4443cf50aa0e5d98d8129a5c65c6c76a838b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9b5b444 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Refactor command-line handling of GUI options.
    
    Both GTK and Qt both use the same command-line options, so refactor
    the parsing and (possibly) applying of those arguments to a single
    location.
    
    Ping-Bug: 12546
    Change-Id: Ib31e576c509c5d3d21c33d3247640d9f9c68661b
    Reviewed-on: https://code.wireshark.org/review/16006
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  deef1dc   cmake: add PIDL dissector generation support
    adds  9b5b444   Refactor command-line handling of GUI options.


Summary of changes:
 ui/CMakeLists.txt             |    1 +
 ui/Makefile.common            |    2 +
 ui/commandline.c              |  637 ++++++++++++++++++++++++++++++++++++++
 ui/commandline.h              |   86 ++++++
 ui/gtk/about_dlg.c            |    5 +
 ui/gtk/main.c                 |  678 +++++------------------------------------
 ui/gtk/main.h                 |    6 +-
 ui/qt/about_dialog.cpp        |    3 +
 ui/qt/wireshark_application.h |    6 +-
 wireshark-qt.cpp              |  624 ++++---------------------------------
 10 files changed, 875 insertions(+), 1173 deletions(-)
 create mode 100644 ui/commandline.c
 create mode 100644 ui/commandline.h