Wireshark-commits: [Wireshark-commits] master b22e1ae: ssh: packets after SSH_MSG_NEWKEYS are encry
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Jun 2016 17:05:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b22e1aeb58a2e620efca1a2f1cf37f179f3773a8
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b22e1ae by Kenny Root (kenny@xxxxxxxxx):

    ssh: packets after SSH_MSG_NEWKEYS are encrypted
    
    According to RFC 4253 section 7.3, once the SSH_MSG_NEWKEYS is received
    all packets after that will be encrypted using the negotiated keys. This
    can happen in the middle of a frame, so account for the offset in the
    frame where this happens.
    
    Change-Id: Ibc3b06a4bdfe38ae15b0e65afac6f5d3646cb58d
    Reviewed-on: https://code.wireshark.org/review/15965
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  9a5e6a6   DCE/RPC proto_tree_add_boolean -> proto_tree_add_bitmask_with_flags
    adds  b22e1ae   ssh: packets after SSH_MSG_NEWKEYS are encrypted


Summary of changes:
 epan/dissectors/packet-ssh.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)