Wireshark-commits: [Wireshark-commits] master f749a64: cmake: Detect proper large file defines even
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f749a64280051663f04fa5dfd11a50e3d4ce4e77
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
f749a64 by Balint Reczey (balint@xxxxxxxxxxxxxxx):
cmake: Detect proper large file defines even with -Wno-error
Without this change large file support was detected as available
even when it was not without additional flags on 32 architectures.
As a result mergecap and other programs are built without large
file support causing mergecap not being able to write files
bigger than 2GB on i386 systems. This used to work properly
with autotools builds, but not with CMake ones.
Change-Id: Ibfd043342b2a48310d2ac9d760e6404a701c5808
Reviewed-on: https://code.wireshark.org/review/15937
Petri-Dish: Balint Reczey <balint@xxxxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
Actions performed:
from 4962ea6 qt: move free_stat_tables from SimpleStatisticsDialog::fillTree to ~SimpleStatisticsDialog.
adds f749a64 cmake: Detect proper large file defines even with -Wno-error
Summary of changes:
cmake/TestFileOffsetBits.c | 8 +++++++-
cmake/TestLargeFiles.c.cmakein | 15 ++++++++++++---
2 files changed, 19 insertions(+), 4 deletions(-)