Wireshark-commits: [Wireshark-commits] master-1.12 de3a604: Let the calculated window scale be 16 b
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 15 Jun 2016 13:06:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=de3a60416a025bff421718dbb467ec08ff352982
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

de3a604 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Let the calculated window scale be 16 bit wide.
    
    Even though TCP window scale shift is only 8 bits, the scale
    calculated from it is max 16384. therefor a 16 bit value.
    Let the tree item map to the single byte in the TVB, while
    allowing the value to be 16 bit.
    
    Bug: 12525
    Change-Id: I41cebc62f6b8b09e13efa5f3b7432001e8d994e1
    Reviewed-on: https://code.wireshark.org/review/15914
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit b26e757b310180bd2ab867dd5ad0cc0261993135)
    Reviewed-on: https://code.wireshark.org/review/15915
    (cherry picked from commit c62ffc4cbc228da25df7bebb663546de07a74237)
    Reviewed-on: https://code.wireshark.org/review/15916
    

Actions performed:

    from  199392b   Actually progress through the command data (CID-281394)
    adds  de3a604   Let the calculated window scale be 16 bit wide.


Summary of changes:
 epan/dissectors/packet-tcp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)