Wireshark-commits: [Wireshark-commits] master c19e6c2: cmake: fix ENABLE_ASAN detection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 15 Jun 2016 06:03:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c19e6c24067fd0aa1ea628de85f25ef9ece08839
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c19e6c2 by Peter Wu (peter@xxxxxxxxxxxxx):

    cmake: fix ENABLE_ASAN detection
    
    Do not add -fsanitize=undefined when ASAN is requested, UBSAN is a
    different feature (which could be added later as desired). This makes
    the -DENABLE_ASAN=1 option match the autotools --enable-asan option.
    
    Fail hard if ASAN support is requested but not supported, this avoids
    surprises when something is wrong. Fix ASAN detection by setting the
    linker option too.
    
    Note: if you have previously set ENABLE_ASAN=1 with the broken ASAN
    detection, you have to clear your CMakeCache.txt file to redo the
    detection.
    
    Change-Id: Iba6ca0da0336eccedd0cf31a251baad9d1aff5b4
    Reviewed-on: https://code.wireshark.org/review/15908
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3a59021   Change how dissectors do late-field-registration to avoid a double-registration assertion.
    adds  c19e6c2   cmake: fix ENABLE_ASAN detection


Summary of changes:
 CMakeLists.txt |   27 ++++++++++++---------------
 1 file changed, 12 insertions(+), 15 deletions(-)