Wireshark · Wireshark-commits: [Wireshark-commits] master 3a59021: Change how dissectors do late-field-registration to avoid a doub

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a590217ac60d626cb126aff593b43901585224c
Submitter: Jaap Keuter (jaap.keuter@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3a59021 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Change how dissectors do late-field-registration to avoid a double-registration
    assertion.
    
    If a dissector forces registration of fields during dissection it needs to do
    so in a way that clears the prefix registration.  Otherwise epan will call the
    registration routine a 2nd time (which will cause us to assert out) if a user
    types a display filter (with the dissector's prefix) that doesn't exist.
    
    Update the proto_register_prefix() comments to reflect this.
    
    Change-Id: I3ce29243395fb55192bb5dfd950baa88410ac136
    Reviewed-on: https://code.wireshark.org/review/15881
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  22fd85d   mount: fix a memory leak
    adds  3a59021   Change how dissectors do late-field-registration to avoid a double-registration assertion.


Summary of changes:
 epan/dissectors/packet-diameter.c      |    4 +---
 epan/dissectors/packet-radius.c        |   10 +++++-----
 epan/proto.h                           |    3 ++-
 plugins/wimaxasncp/packet-wimaxasncp.c |    7 ++-----
 4 files changed, 10 insertions(+), 14 deletions(-)