Wireshark-commits: [Wireshark-commits] master-2.0 9412cc1: CORBA IDL: compile dissectors with /Ox w
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 15 Jun 2016 01:53:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9412cc17bcfde026d4e78380a5c1f3bd0a207549
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

9412cc1 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    CORBA IDL: compile dissectors with /Ox when using MSVC2013 x64
    
    By default Windows files are compiled with /O2 optimization flag (that brings the best performance).
    But MSVC2013 x64 compiler generates buggy code for CORBA IDL dissectors.
    Let's downgrade the optimization to /Ox for those files specifically.
    
    Bug: 12495
    Change-Id: Ibbb532653808d915c82bd20b55dd9e68d86b1207
    Reviewed-on: https://code.wireshark.org/review/15884
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 581a17af40b84ef0c9e7f41ed0795af345b61ce1)
    Conflicts:
    	epan/CMakeLists.txt
    	epan/dissectors/CMakeLists.txt
    Reviewed-on: https://code.wireshark.org/review/15910
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  2a2955d   USB: fix dissection of URB setup when the payload was claimed by a sub dissector
    adds  9412cc1   CORBA IDL: compile dissectors with /Ox when using MSVC2013 x64


Summary of changes:
 epan/CMakeLists.txt             |   30 ++++++++++++++++++++++++++++--
 epan/dissectors/Makefile.common |    5 +++--
 2 files changed, 31 insertions(+), 4 deletions(-)