Wireshark-commits: [Wireshark-commits] master 40a3cbf: Qt: fix crash when opening Expert Info dialo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 Jun 2016 21:24:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=40a3cbfca5e8d7d7c4445795674575510fc70d29
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

40a3cbf by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: fix crash when opening Expert Info dialog
    
    g6ff19ff tried to access cinfo by following a chain of pointers from
    expert_info. Access cinfo from cap_file_, which is more reliable. While
    we are at it, let's explicitly check the pointer validity.
    
    Change-Id: I0da72c5b1d2230a49c125a1b57c81c3115c4f2fb
    Reviewed-on: https://code.wireshark.org/review/15901
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  c0c00f4   Give unique names to a bunch of reserved, experimental, etc., AVPs.
    adds  40a3cbf   Qt: fix crash when opening Expert Info dialog


Summary of changes:
 ui/qt/expert_info_dialog.cpp |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)