Wireshark-commits: [Wireshark-commits] master 8b6ea37: Qt: Make the capture filter read-only only i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Jun 2016 13:14:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b6ea372c1ba66667a985d3f90d3daef131bb1ed
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8b6ea37 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Make the capture filter read-only only in main welcome.
    
    As noted in gb7897dd, CaptureFilterCombo needs to be read-only until the
    app is initialized. Move the code to do so to MainWelcome, otherwise the
    capture filter entry in CaptureInterfacesDialog starts out read-only and
    stays that way. Disable / enable the entire CaptureFilterCombo instead
    of setting its lineEdit read-only status, which provides a stronger
    visual indicator.
    
    Change-Id: Ic7bf5b5631b861ecf4dc8cca67beb5bf4ed27510
    Reviewed-on: https://code.wireshark.org/review/15859
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6ff19ff   Qt: Add the Info column contents to Expert Info.
    adds  8b6ea37   Qt: Make the capture filter read-only only in main welcome.


Summary of changes:
 ui/qt/capture_filter_combo.cpp |    3 +--
 ui/qt/main_welcome.cpp         |    6 +++++-
 2 files changed, 6 insertions(+), 3 deletions(-)