Wireshark-commits: [Wireshark-commits] master 2d095de: Move Gateway Control Protocol (Context Track
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Jun 2016 11:22:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d095de05328a7209fefa31d5b3c26713f4b5ad2
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2d095de by Michael Mann (mmann78@xxxxxxxxxxxx):

    Move Gateway Control Protocol (Context Tracking) into packet-h248.h
    
    The Gateway Control Protocol (Context Tracking) is used by both H248
    and MEGACO, so the functionality was refactored to epan, but should
    really be kept in the dissector directory to minimize (and eventually
    completely remove) the epan directory's dependence on it.
    
    Change-Id: I387b46aecde97234086bfdb7d8c546854fa301cd
    Reviewed-on: https://code.wireshark.org/review/15798
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  68ef5db   Add missing scale in TDS type info
    adds  2d095de   Move Gateway Control Protocol (Context Tracking) into packet-h248.h


Summary of changes:
 epan/CMakeLists.txt                              |    1 -
 epan/Makefile.common                             |    2 -
 epan/dissectors/asn1/h248/packet-h248-template.c |  745 ++++++++++++++++++++-
 epan/dissectors/asn1/h248/packet-h248-template.h |  177 ++++-
 epan/dissectors/packet-h248.c                    |  755 ++++++++++++++++++++-
 epan/dissectors/packet-h248.h                    |  177 ++++-
 epan/dissectors/packet-h248_10.c                 |    1 +
 epan/dissectors/packet-h248_3gpp.c               |    5 +
 epan/dissectors/packet-h248_annex_c.c            |    6 +
 epan/dissectors/packet-h248_q1950.c              |    5 +
 epan/dissectors/packet-megaco.c                  |    6 +-
 epan/gcp.c                                       |  782 ----------------------
 epan/gcp.h                                       |  224 -------
 ui/voip_calls.c                                  |    4 +
 14 files changed, 1849 insertions(+), 1041 deletions(-)
 delete mode 100644 epan/gcp.c
 delete mode 100644 epan/gcp.h