Wireshark-commits: [Wireshark-commits] master-2.0 92a3cf6: qt: Refresh local interface list only wh
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=92a3cf6f26ee4e543c8e735bead918c22b5be3d4
Submitter: Dario Lombardo (lomato@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark
Commits:
92a3cf6 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxxx):
qt: Refresh local interface list only when interfaces added/removed
Whenever data is received on the iface monitor socket the list of
local network interfaces is refreshed. No check whether an interface
is really added/removed is done. Changes to network interface options
like promiscous mode flag generate traffic on the iface monitor socket
that not necessarily mean an interface was brought up or down resulting
in an unwanted refresh of local interfaces.
When local interfaces are refreshed selected capture interface(s) get
deselected. This in turn makes "Restart current capture" fail with a no
capture interface selected error.
Fixed by moving the refresh action from socket monitor callback to iface
monitor callback where interface up/down status is known.
Bug: 11834
Change-Id: Iffd39c3240049880b5a8311bc6484f3d1433f387
Reviewed-on: https://code.wireshark.org/review/12317
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
(cherry picked from commit 74747489ac9b67a06a4f53e14de66c0842165136)
Reviewed-on: https://code.wireshark.org/review/15831
Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
Actions performed:
from 09de289 More comment clarification.
adds 92a3cf6 qt: Refresh local interface list only when interfaces added/removed
Summary of changes:
ui/qt/wireshark_application.cpp | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
