Wireshark-commits: [Wireshark-commits] master e00d73a: dcerpc-browser: don't THROW() an exception f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 11 Jun 2016 17:24:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e00d73aaef49a8b1f1dd7b93a0244ada82728123
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e00d73a by Martin Kaiser (wireshark@xxxxxxxxx):

    dcerpc-browser: don't THROW() an exception from a dissector
    
    the condition for THROW() will never be true
    
    there's no way to decrement offset below its initial value
    the dissect_browser_TYPE_x_data() functions read a uint32 and increment
    offset by 4 + the uint32 value that was read
    
    Change-Id: Ia5a63e714ffa0add601960d858452152e4d9b10b
    Reviewed-on: https://code.wireshark.org/review/15627
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c755c88   iso14443: dissect attrib's p3 byte
    adds  e00d73a   dcerpc-browser: don't THROW() an exception from a dissector


Summary of changes:
 epan/dissectors/packet-dcerpc-browser.c |   12 ------------
 1 file changed, 12 deletions(-)