Wireshark-commits: [Wireshark-commits] master c1a3829: Remove superfluous size checks (CID-1158694)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 8 Jun 2016 10:21:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c1a38296e79ecaa2a23707a7672097ac91205ebb
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c1a3829 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Remove superfluous size checks (CID-1158694)
    
    Don't try to add expert items for size < 1 when this code isn't
    executed for size == 0. (note: size is unsigned)
    
    Change-Id: Ieb3d2593d4bb5f175ac368ef38571511b4f56f25
    Reviewed-on: https://code.wireshark.org/review/15774
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  74484c6   Apply the prefix operator to iterators.
    adds  c1a3829   Remove superfluous size checks (CID-1158694)


Summary of changes:
 epan/dissectors/packet-cip.c |   27 +++------------------------
 1 file changed, 3 insertions(+), 24 deletions(-)