Wireshark-commits: [Wireshark-commits] master 5023356: Use separate main geometry settings for Qt a
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=502335612c4c35a4bf7f19ffa7500ea1aac7d43f
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
5023356 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Use separate main geometry settings for Qt and GTK+.
Qt and GTK+ can have wildly different notions about the top-left
position of the main window, particularly in multiple-screen
configurations. For example, on OS X with the following monitor
arrangment:
g .---------.
| |
| |
q--------.| |
| |`---------'
| |
`--------'
GTK+ positions windows relative to 'g' and Qt positions windows relative
to 'q'. As a result it's easy for one UI to clobber the settings of the
other.
Split the geometry_main_x and geometry_main_y recent settings into Qt
and GTK+ versions.
In the Qt UI, try moving the main window onscreen before falling back to
the default geometry. This keeps us from losing our size settings.
Add a link to a Qt geometry bug.
Change-Id: If7ae0dcc1719e646299ee3bbf1c88743f655c9a0
Ping-Bug: 12389
Reviewed-on: https://code.wireshark.org/review/15775
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 73286c4 Support reading in and storing multiple Section Header and Name Resolution blocks.
adds 5023356 Use separate main geometry settings for Qt and GTK+.
Summary of changes:
ui/gtk/main.c | 8 ++++----
ui/qt/main_window.cpp | 11 ++++++++++-
ui/recent.c | 16 ++++++++++++++++
ui/recent.h | 2 ++
4 files changed, 32 insertions(+), 5 deletions(-)
