Wireshark · Wireshark-commits: [Wireshark-commits] master-2.0 9d69a1e: Don't sign extend unsigned integer fields larger than 32 bit

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9d69a1e98eddafc9d74a3931f9a2af45c72f0e8f
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

9d69a1e by Jens Kilian (jens.kilian@xxxxxxxxxxxxx):

    Don't sign extend unsigned integer fields larger than 32 bits.
    
    Fix a bug in proto_tree_set_uint64() which caused fields to be sign extended.
    (This only showed up when a non-zero bitmask was present.)
    
    Change-Id: Ibcc986e3d42f97348966ea66c2ae9fca73b09992
    Reviewed-on: https://code.wireshark.org/review/15764
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    (cherry picked from commit 767a59e54e6df17f7d8e2c6806ce16062d17e6d7)
    Reviewed-on: https://code.wireshark.org/review/15765
    

Actions performed:

    from  1d6dd6a   afs: eliminate "malformed packet" false alarms
    adds  9d69a1e   Don't sign extend unsigned integer fields larger than 32 bits.


Summary of changes:
 epan/proto.c |    4 ----
 1 file changed, 4 deletions(-)