Wireshark-commits: [Wireshark-commits] master 57ef06e: *_stdup_printf -> strdup for "single string
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 6 Jun 2016 06:04:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=57ef06e242dbbce390547d9711f810fc60829219
Submitter: Jaap Keuter (jaap.keuter@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

57ef06e by Michael Mann (mmann78@xxxxxxxxxxxx):

    *_stdup_printf -> strdup for "single string only" formatting.
    
    Done for performance improvements.
    
    This could probably be done in checkAPIs.pl, but this was just
    a quick manual check with grepping.
    
    Change-Id: I91ff102cb528bb00fa2f65489de53890e7e46f2d
    Reviewed-on: https://code.wireshark.org/review/15751
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  6333b98   DNP: Make checkhf (ei ?) happy
    adds  57ef06e   *_stdup_printf -> strdup for "single string only" formatting.


Summary of changes:
 capchild/capture_sync.c                 |    2 +-
 caputils/airpcap_loader.c               |    4 ++--
 echld/echld-int.h                       |    2 +-
 epan/dissectors/asn1/ldap/ldap.cnf      |    4 ++--
 epan/dissectors/asn1/ros/ros-err.cnf    |    2 +-
 epan/dissectors/asn1/ros/ros-inv.cnf    |    2 +-
 epan/dissectors/asn1/ros/ros-res.cnf    |    2 +-
 epan/dissectors/file-pcapng.c           |   12 ++++--------
 epan/dissectors/packet-dcerpc-spoolss.c |    8 ++++----
 epan/dissectors/packet-devicenet.c      |    2 +-
 epan/dissectors/packet-diameter_3gpp.c  |   12 ++++--------
 epan/dissectors/packet-dof.c            |   24 ++++++++++++------------
 epan/dissectors/packet-dtls.c           |    2 +-
 epan/dissectors/packet-h450-ros.c       |    6 +++---
 epan/dissectors/packet-isakmp.c         |    2 +-
 epan/dissectors/packet-k12.c            |    2 +-
 epan/dissectors/packet-lbmpdmtcp.c      |    4 ++--
 epan/dissectors/packet-lbmr.c           |    4 ++--
 epan/dissectors/packet-lbtrm.c          |    4 ++--
 epan/dissectors/packet-lbtru.c          |    4 ++--
 epan/dissectors/packet-lbttcp.c         |    4 ++--
 epan/dissectors/packet-ldap.c           |    4 ++--
 epan/dissectors/packet-q932-ros.c       |    6 +++---
 epan/dissectors/packet-rpc.c            |    2 +-
 epan/dissectors/packet-scsi.c           |    2 +-
 epan/dissectors/packet-ssl-utils.c      |    8 ++++----
 epan/dissectors/packet-ssl.c            |    2 +-
 epan/dissectors/packet-zbee-nwk-gp.c    |    4 ++--
 epan/dissectors/packet-zbee-nwk.c       |    4 ++--
 epan/prefs.c                            |    2 +-
 extcap/ssh-base.c                       |    4 ++--
 ui/gtk/capture_dlg.c                    |    6 +++---
 ui/gtk/filter_utils.c                   |    6 +++---
 ui/gtk/main.c                           |    4 ++--
 ui/gtk/prefs_column.c                   |    6 +++---
 ui/gtk/proto_hier_stats_dlg.c           |    4 ++--
 ui/gtk/sctp_assoc_analyse.c             |    2 +-
 ui/gtk/sctp_stat_dlg.c                  |    2 +-
 ui/gtk/stats_tree_stat.c                |    4 ++--
 ui/iface_lists.c                        |    4 ++--
 ui/qt/manage_interfaces_dialog.cpp      |    2 +-
 wiretap/btsnoop.c                       |    6 +++---
 wiretap/dct3trace.c                     |    4 ++--
 wiretap/erf.c                           |    2 +-
 wiretap/netmon.c                        |    2 +-
 wiretap/ngsniffer.c                     |    4 ++--
 wiretap/pcap-common.c                   |    2 +-
 wiretap/pcapng.c                        |    6 +++---
 wiretap/peektagged.c                    |    2 +-
 wiretap/vms.c                           |    6 +++---
 50 files changed, 106 insertions(+), 114 deletions(-)