Wireshark · Wireshark-commits: [Wireshark-commits] master adee685: Directly use wtap_opttypes calls to fetch SHB options.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=adee6850898a5469850a157c5816996691855ed2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

adee685 by Guy Harris (guy@xxxxxxxxxxxx):

    Directly use wtap_opttypes calls to fetch SHB options.
    
    Don't put them in the summary structure; the summary routines should
    calculate summary statistics, not dig up every bit of information that
    *could* appear in a summary.
    
    Instead, have the GUI code call wtap_file_get_shb() to get the SHB
    information and call wtap_optionblock_get_option_string() to fetch the
    option values.
    
    Move the option code definitions into wtap_opttypes.h, as they're used
    by the API.
    
    Change-Id: Icef11f5fb30fdc3df1bb0208aae9ed0aebaf0182
    Reviewed-on: https://code.wireshark.org/review/15748
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  56e33a5   DNS: Update draft-ietf-dnsop-cookie to final rfc (7873)
    adds  adee685   Directly use wtap_opttypes calls to fetch SHB options.


Summary of changes:
 capinfos.c                               |    1 -
 summary.c                                |   15 -----
 summary.h                                |    5 --
 ui/gtk/summary_dlg.c                     |  104 ++++++++++++++++++------------
 ui/qt/capture_file_properties_dialog.cpp |   60 +++++++++--------
 wiretap/pcapng.h                         |   87 -------------------------
 wiretap/wtap_opttypes.h                  |   96 +++++++++++++++++++++++++++
 7 files changed, 193 insertions(+), 175 deletions(-)